Fix nested comment warning in RX GCC ports#550
Merged
fdesbiens merged 1 commit intoJun 16, 2026
Conversation
The RX GCC assembly port contains an unclosed C-style comment in tx_thread_context_save.S. Because .S files are passed through the C preprocessor before assembly, the nested comment can trigger GCC warnings. Close the affected comment block without changing assembly instructions or runtime behavior. Signed-off-by: FranCDoc <fchiesadoc@gmail.com>
Contributor
|
Hi @francdoc. Thank you for this contribution. I will merge to dev now, and it will ship in our Q3 2026 release (September). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RX GCC assembly port contains an unclosed C-style comment in
tx_thread_context_save.S. As discussed in #397,.Sfiles are passed through the C preprocessor before assembly, so the later C-style comment can trigger GCC warnings. The warning is small, but it adds avoidable noise to RX GCC builds.This PR closes the affected comment block without changing assembly instructions or runtime behavior.
Validation
git diff --check.8.3.0.202405-GNURX.tx_thread_context_save.Sfiles with-Wcomment -Werror=comment.-misa=v1,-misa=v2, and-misa=v3.The RX GCC preprocessing, assembly compilation, and standalone static-library builds completed successfully.
PR checklist